• code snippets
  • all code snippets/
  • popular code snippets/
  • your code snippets
• extras
• blog
• about snipplr

• Big /
• Small

Posted By

joshnunn on 09/10/09

Tagged

year test java method leap

Versions (?)

09/10/09 07:37am

 / Published in: Java

 

	public boolean isLeapYear(){
		boolean leapYear;
		int divideByFour = year % 4;
		int divideBy100 = year % 100;
		int divideBy400 = year % 400;
		if (divideBy400 == 0){
			leapYear = true;
		} else if (divideBy100 == 0){
			leapYear = false;
		} else if (divideByFour == 0){
			leapYear = true;
		} else {
			leapYear = false;
		}
		return leapYear;
	}

Report this snippet   Tweet

Comments

Subscribe to comments

Posted By: DannyB on September 14, 2009

Here is what I use:

public static boolean isLeapYear( int year ) {
    if( (year % 4) != 0 ) return false;

    if( (year % 100) != 0 ) return true;

    return (year % 400) == 0;
}

Why perform the mod by 100 and divide by 400 every time. Most years never need those mod operations performed. Then, why test for mod by 400 first, when seldom does this test need to be performed. Ditto mod by 100. For almost all years, the mod by 4 test must be performed, so let's do it first, and skip the other mod operations and conditional tests most of the time. Not only is it more efficient, this function is simpler source code, and probably simpler object code too.

I put both functions in a for loop from 1 to 3000 and got identical results.

Posted By: joshnunn on September 17, 2009

Thanks for the alternate code. You're absolutely right about cutting out a lot of unneccessary stuff.

Thanks for helping out a n00b!