Comments on snippet: 'Remove Duplicate Values from Array'

AlexWolfe said on 07/Dec/2010

Tue, 07 Dec 2010 14:52:47 UTC

Would it be nice to set found = false; That way you could say if(found) newArr.push instead of if(!found). Both work, just seems like it would be more elegant. Also, I'm not a big fan of setting vars to undefined. If you set a variable to undefined because if you don't even declare a var its returns undefined.

AlexWolfe said on 07/Dec/2010

Tue, 07 Dec 2010 15:00:24 UTC

Oops, scratch that. I read the code wrong. Sorry, !found definitely makes more sense because you are trying to avoid duplicates.

ronydee said on 12/Dec/2010

Sun, 12 Dec 2010 04:24:28 UTC

this function extends the Array object and cleans the duplicates from the input Array instead of creating a new one: Array.prototype.unique = function unique() { var i = 0; while (i < this.length) { var current = this[i]; for (k = this.length; k > i; k--) { if (this[k] === current) { this.splice(k,1); } } i++; } return this; } var myarray = ['jeffrey', 'allie', 'patty', 'damon', 'zach', 'jeffrey', 'allie', 'patty', 'damon', 'zach', 'joe']; alert(myarray.unique().join(', '));

dvdrtrgn said on 14/Dec/2010

Tue, 14 Dec 2010 16:29:31 UTC

Let's golf: `function unique(arr,dup) { dup = dup ? arr.concat() : arr; for (var i=0; i < dup.length; i++) if (dup.indexOf(dup[i]) < i) dup.splice(i--); return dup; }`